[flashrom-gerrit] Change in flashrom[master]: Add support for Intel Emmitsburg PCH

[Nico Huber (Code Review)]

Attention is currently required from: Arthur Heymans, Jonathan Zhang, David Hendricks, Edward O'Callaghan, Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57635 )

Change subject: Add support for Intel Emmitsburg PCH
......................................................................

Patch Set 3:

(1 comment)

File ich_descriptors.c:

https://review.coreboot.org/c/flashrom/+/57635/comment/632f44c9_3df9f285 
PS3, Line 952: Ibex Peak is historically used as the default
> So if we add a newer chipset with `ICCRIBA == 0x00` and more straps then it should become the defaul […]

I wouldn't say "should" but it definitely could.

Personally, as this branch seems complex enough already, I'd
first check if there is no easier way to distinguish server
descriptors from client ones.

Also, please note that everything done about Emmitsburg so far
(including what I wrote above) makes the assumption that it's
right to return _LEWISBURG for it. I don't know if that is
correct.