Attention is currently required from: Arthur Heymans, Jonathan Zhang, David Hendricks, Edward O'Callaghan, Angel Pons.
View Change
1 comment:
File ich_descriptors.c:
Patch Set #3, Line 952: Ibex Peak is historically used as the default
So if we add a newer chipset with `ICCRIBA == 0x00` and more straps then it should become the defaul […]
I wouldn't say "should" but it definitely could.
Personally, as this branch seems complex enough already, I'd
first check if there is no easier way to distinguish server
descriptors from client ones.
Also, please note that everything done about Emmitsburg so far
(including what I wrote above) makes the assumption that it's
right to return _LEWISBURG for it. I don't know if that is
correct.
To view, visit change 57635. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1edae9163b910c3831adc82c90840fa965479451
Gerrit-Change-Number: 57635
Gerrit-PatchSet: 3
Gerrit-Owner: David Hendricks
Gerrit-Reviewer: Angel Pons <angel.pons@9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur.heymans@9elements.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Jonathan Zhang <jonzhang@fb.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur.heymans@9elements.com>
Gerrit-Attention: Jonathan Zhang <jonzhang@fb.com>
Gerrit-Attention: David Hendricks <david.hendricks@gmail.com>
Gerrit-Attention: David Hendricks
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Angel Pons <angel.pons@9elements.com>
Gerrit-Comment-Date: Sat, 18 Sep 2021 10:59:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: David Hendricks <david.hendricks@gmail.com>
Gerrit-MessageType: comment