24 Dec
2019
24 Dec
'19
12:28 a.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/37776 )
Change subject: Add -- to make clean ......................................................................
Patch Set 1: Code-Review+2
No matter where that file came from, we shouldn't produce invalid `rm` invocations based on files lying around.
But please fix the commit summary. I was confused as well, thought you wanted to delete a file called `--`, i.e. run `rm -f -- --`.
--
To view, visit https://review.coreboot.org/c/flashrom/+/37776
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2517ffac975f3df75f706350a07f189a98a11b7c
Gerrit-Change-Number: 37776
Gerrit-PatchSet: 1
Gerrit-Owner: Ryan O'Leary ryanoleary@google.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 23 Dec 2019 23:28:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment