Attention is currently required from: Felix Singer, Anastasia Klimchuk, Peter Marheine. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63826 )
Change subject: meson: use `platform/` as subdir() ......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/63826/comment/f3a00d35_03b29698 PS3, Line 7: outsource
I would use "move"
Entirely new commit message
https://review.coreboot.org/c/flashrom/+/63826/comment/e61fc457_801f5a73 PS3, Line 8:
Please state the reason for this change. […]
Is it more obvious now?
File meson.build:
https://review.coreboot.org/c/flashrom/+/63826/comment/3ec270c3_7afcd5bf PS2, Line 80: host_is_x86 = ['x86', 'x86_64'].contains(host_machine.cpu_family())
Okay so maybe you can update commit message and add more info about future plans?
Is the single sentence enough?
https://review.coreboot.org/c/flashrom/+/63826/comment/44807d66_41bbeb73 PS2, Line 133: if host_machine.system() in ['cygwin', 'windows']
Yes, we can move it here first. […]
I've decided against putting IS_WINDOWS here and only put stuff from the `platform/` directory there. OK?