Attention is currently required from: Felix Singer, Anastasia Klimchuk, Peter Marheine.

View Change

4 comments:

• Commit Message:

  • Patch Set #3, Line 7: outsource

    I would use "move"

    Entirely new commit message

  • Patch Set #3, Line 8:

    Please state the reason for this change. […]

    Is it more obvious now?

• File meson.build:

  • Patch Set #2, Line 80: host_is_x86 = ['x86', 'x86_64'].contains(host_machine.cpu_family())

    Okay so maybe you can update commit message and add more info about future plans?

    Is the single sentence enough?

  • Patch Set #2, Line 133: if host_machine.system() in ['cygwin', 'windows']

    Yes, we can move it here first. […]

    I've decided against putting IS_WINDOWS here and only put stuff from the `platform/` directory there.
    OK?

To view, visit change 63826. To unsubscribe, or for help writing mail filters, visit settings.