David Tomaschik has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33639 )
Change subject: Add support for MX25U25635F
......................................................................
Patch Set 3:
(1 comment)
Thanks for the feedback, and sorry for the slow iteration time.
https://review.coreboot.org/#/c/33639/1/flashchips.c
File flashchips.c:
https://review.coreboot.org/#/c/33639/1/flashchips.c@8884
PS1, Line 8884: {
: .eraseblocks = { {4 * 1024, 8192} },
: .block_erase = spi_block_erase_20,
: }, {
: .eraseblocks = { {32 * 1024, 1024} },
: .block_erase = spi_block_erase_52,
: }, {
: .eraseblocks = { {64 * 1024, 512} },
: .block_erase = spi_block_erase_d8,
: }, {
Sorry, I forgot to mention that order matters, the native 4BA versions […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/33639
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5bdcd32acd1942edf65e50bce0f81c836095ee8c
Gerrit-Change-Number: 33639
Gerrit-PatchSet: 3
Gerrit-Owner: David Tomaschik
davidtomaschik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Tomaschik
davidtomaschik@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 27 Jun 2019 16:47:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Tomaschik
davidtomaschik@google.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment