Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46140 )
Change subject: WIP: s25f.c: import file from cros flashrom ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/flashrom/+/46140/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/46140/2//COMMIT_MSG@9 PS2, Line 9: Imported "Adapted"
I think you are at the stage to flesh out this commit message with details now.
https://review.coreboot.org/c/flashrom/+/46140/5/Makefile File Makefile:
https://review.coreboot.org/c/flashrom/+/46140/5/Makefile@641 PS5, Line 641: s25f.o add this to the meson build system as well
https://review.coreboot.org/c/flashrom/+/46140/2/chipdrivers.h File chipdrivers.h:
https://review.coreboot.org/c/flashrom/+/46140/2/chipdrivers.h@24 PS2, Line 24: #include "writeprotect.h" /* for modifier_bits */
It provides the modifier_bits struct, used by the s25f_{set,get}_modifier_bits() prototypes. […]
I hear you however I think it's worth separating out into another commit. write-protect support is its own thing over the base level chip support. It makes the commits easier to review as well. just unstage the commit and make it a follow up commit, should be easy enough to separate out the hunks for this.