View Change

3 comments:

• Commit Message:

  • Patch Set #2, Line 9: Imported

    "Adapted"

    I think you are at the stage to flesh out this commit message with details now.

• File Makefile:

  • Patch Set #5, Line 641: s25f.o

    add this to the meson build system as well

• File chipdrivers.h:

  • Patch Set #2, Line 24: #include "writeprotect.h" /* for modifier_bits */

    It provides the modifier_bits struct, used by the s25f_{set,get}_modifier_bits() prototypes. […]

    I hear you however I think it's worth separating out into another commit. write-protect support is its own thing over the base level chip support. It makes the commits easier to review as well. just unstage the commit and make it a follow up commit, should be easy enough to separate out the hunks for this.

To view, visit change 46140. To unsubscribe, or for help writing mail filters, visit settings.