[flashrom-gerrit] Change in flashrom[master]: dediprog.c: Split up compound conditional statement

[Anastasia Klimchuk (Code Review)]

Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51706 )

Change subject: dediprog.c: Split up compound conditional statement
......................................................................

Patch Set 1:

(1 comment)

File dediprog.c:

https://review.coreboot.org/c/flashrom/+/51706/comment/39f0a0ba_afd1319b 
PS1, Line 1276: 	if (register_spi_master(&spi_master_dediprog))
              : 		return 1;
              : 
              : 	return dediprog_set_leds(LED_NONE);
> I've preserved the original behaviour of the code, just moved the `dediprog_set_leds` call out of th […]

Yeah, I understand this is the original behaviour, but I also think it can be improved.
Returning an error when LED fails is of course justified, but registering the master when LED fails and init fails is probably not.
I agree this can be a separate patch though.