Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.

View Change

1 comment:

• File dediprog.c:

  • Patch Set #1, Line 1276:

    	if (register_spi_master(&spi_master_dediprog))
    		return 1;
    
    	return dediprog_set_leds(LED_NONE);
    

    I've preserved the original behaviour of the code, just moved the `dediprog_set_leds` call out of th […]

    Yeah, I understand this is the original behaviour, but I also think it can be improved.
    Returning an error when LED fails is of course justified, but registering the master when LED fails and init fails is probably not.
    I agree this can be a separate patch though.

To view, visit change 51706. To unsubscribe, or for help writing mail filters, visit settings.