Attention is currently required from: Edward O'Callaghan.
Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69517 )
Change subject: flashrom.c: Supplement `chip->unlock()` calls with wp unlocking ......................................................................
Patch Set 8:
(4 comments)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/69517/comment/07c8b3d9_3885c720 PS7, Line 1687: if (ret != FLASHROM_WP_OK) : return -1; : : return 0;
ternary operator seems more concise here.
Done
https://review.coreboot.org/c/flashrom/+/69517/comment/3a76eb2c_83fabe59 PS7, Line 1696: unlocked_cfg
be consistent `unlocked_wp_cfg`
Done
https://review.coreboot.org/c/flashrom/+/69517/comment/719c77ca_217f959a PS7, Line 1695: struct flashrom_wp_cfg *original_wp_cfg = NULL; : struct flashrom_wp_cfg *unlocked_cfg = NULL;
Do these need to be initialised, if done unnecessarily it can obscure static analysis.
Done
https://review.coreboot.org/c/flashrom/+/69517/comment/f65fe723_b22d974e PS7, Line 1708: return -1;
are you leaking `original_wp_cfg` on the return here? […]
I fixed resource leaks, in the end I refactored some of this code into a separate function.