Attention is currently required from: Edward O'Callaghan.

View Change

4 comments:

• File flashrom.c:

  • Patch Set #7, Line 1687:

    	if (ret != FLASHROM_WP_OK)
    		return -1;
    
    	return 0;
    

    ternary operator seems more concise here.

    Done

  • Patch Set #7, Line 1696: unlocked_cfg

    be consistent `unlocked_wp_cfg`

    Done

  • Patch Set #7, Line 1695:

    	struct flashrom_wp_cfg *original_wp_cfg = NULL;
    	struct flashrom_wp_cfg *unlocked_cfg = NULL;
    

    Do these need to be initialised, if done unnecessarily it can obscure static analysis.

    Done

  • Patch Set #7, Line 1708: return -1;

    are you leaking `original_wp_cfg` on the return here? […]

    I fixed resource leaks, in the end I refactored some of this code into a separate function.

To view, visit change 69517. To unsubscribe, or for help writing mail filters, visit settings.