Attention is currently required from: Peter Marheine.
Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/84954?usp=email )
Change subject: doc: Add few sections to recent development doc ......................................................................
Patch Set 2:
(10 comments)
Patchset:
PS2: Thank you so much! Your suggestions are super useful, I appreciate a lot.
File doc/release_notes/devel.rst:
https://review.coreboot.org/c/flashrom/+/84954/comment/ec9dca1d_564164b2?usp... : PS1, Line 70: Programmers
Done
https://review.coreboot.org/c/flashrom/+/84954/comment/d2f73af4_24091a83?usp... : PS1, Line 73: * ch347_spi: Add spi clock frequency selection
Done
https://review.coreboot.org/c/flashrom/+/84954/comment/4d6d83f4_7a475dc2?usp... : PS1, Line 78: Bugs fixes
All suggestions are great, and all done.
https://review.coreboot.org/c/flashrom/+/84954/comment/c7b511b6_4488bc60?usp... : PS1, Line 81: * Ensure verify operation completed in full if chip memory modified : : Post-cleanup after processing unaligned region for the case when end : region needs to be extended to align with erase block. Writing was : done correctly, but post-processing of newcontents could cause : one-off offset at the end of the region, which would make : verification appear false-negative
Done
https://review.coreboot.org/c/flashrom/+/84954/comment/5f89c532_fc0bb0a2?usp... : PS1, Line 89: * erasure_layout: Fix init_eraseblock segmentation fault : : Fix a segmentation fault that is caused by accessing an invalid : "subedata" pointer on the last iteration of the init_eraseblock loop. : Instead, short circuit the loop condition to check the sub block index : first, and do not access the invalid pointer if it is the last sub : block. : : Issue was encountered in OpenBSD.
Done
https://review.coreboot.org/c/flashrom/+/84954/comment/1eccc21b_c4d1f8f6?usp... : PS1, Line 99: * Fix FEATURE_NO_ERASE chips and add test for them : : https://ticket.coreboot.org/issues/553
Done
https://review.coreboot.org/c/flashrom/+/84954/comment/c15db004_03eac81e?usp... : PS1, Line 103: * build: never install cmocka : : https://ticket.coreboot.org/issues/561
Done
https://review.coreboot.org/c/flashrom/+/84954/comment/0b08e978_87eda435?usp... : PS1, Line 107: * ichspi: Probe opcode in POSSIBLE_OPCODES[] as well : : https://ticket.coreboot.org/issues/556
Done
https://review.coreboot.org/c/flashrom/+/84954/comment/ce47fd27_80be04af?usp... : PS1, Line 111: * erasure_layout: Erase larger block only when all sub-block need erase : : * erase/write: Deselect all smaller blocks when large block is selected
These are two changes relating to the same issue, so I think they make sense to combine. […]
Done