Attention is currently required from: Peter Marheine.
10 comments:
Patchset:
Thank you so much! Your suggestions are super useful, I appreciate a lot.
File doc/release_notes/devel.rst:
Patch Set #1, Line 70: Programmers
```suggestion […]
Done
Patch Set #1, Line 73: * ch347_spi: Add spi clock frequency selection
```suggestion […]
Done
Patch Set #1, Line 78: Bugs fixes
```suggestion […]
All suggestions are great, and all done.
* Ensure verify operation completed in full if chip memory modified
Post-cleanup after processing unaligned region for the case when end
region needs to be extended to align with erase block. Writing was
done correctly, but post-processing of newcontents could cause
one-off offset at the end of the region, which would make
verification appear false-negative
```suggestion […]
Done
* erasure_layout: Fix init_eraseblock segmentation fault
Fix a segmentation fault that is caused by accessing an invalid
"subedata" pointer on the last iteration of the init_eraseblock loop.
Instead, short circuit the loop condition to check the sub block index
first, and do not access the invalid pointer if it is the last sub
block.
Issue was encountered in OpenBSD.
```suggestion […]
Done
* Fix FEATURE_NO_ERASE chips and add test for them
https://ticket.coreboot.org/issues/553
```suggestion […]
Done
* build: never install cmocka
https://ticket.coreboot.org/issues/561
```suggestion […]
Done
* ichspi: Probe opcode in POSSIBLE_OPCODES[] as well
https://ticket.coreboot.org/issues/556
```suggestion […]
Done
* erasure_layout: Erase larger block only when all sub-block need erase
* erase/write: Deselect all smaller blocks when large block is selected
These are two changes relating to the same issue, so I think they make sense to combine. […]
Done
To view, visit change 84954. To unsubscribe, or for help writing mail filters, visit settings.