Attention is currently required from: Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47655 )
Change subject: it85spi.c: Refactor singleton states into reentrant pattern ......................................................................
Patch Set 11:
(1 comment)
File it85spi.c:
https://review.coreboot.org/c/flashrom/+/47655/comment/de367971_914b2c77 PS11, Line 22: : #if defined(__i386__) || defined(__x86_64__) In answer to your questions regarding 'LPC_IO' && 'LPC_MEMORY'; probably we have a simple initial patch here to convert hunks with this pattern:
``` #ifdef LPC_IO .... #endif #ifdef LPC_MEMORY .... #endif ```
into,
``` #ifdef LPC_IO .... #elif LPC_MEMORY .... #endif ```
and that the defines for either should be at the top of the file with the guard `if defined(__i386__) || defined(__x86_64__)` modified to check if either is defined or just don't compile the file.