Attention is currently required from: Anastasia Klimchuk.
View Change
1 comment:
File it85spi.c:
Patch Set #11, Line 22:
#if defined(__i386__) || defined(__x86_64__)
In answer to your questions regarding 'LPC_IO' && 'LPC_MEMORY'; probably we have a simple initial patch here to convert hunks with this pattern:
```
#ifdef LPC_IO
....
#endif
#ifdef LPC_MEMORY
....
#endif
```
into,
```
#ifdef LPC_IO
....
#elif LPC_MEMORY
....
#endif
```
and that the defines for either should be at the top of the file with the guard `if defined(__i386__) || defined(__x86_64__)` modified to check if either is defined or just don't compile the file.
To view, visit change 47655. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I389d34d62e753c012910aa5ff24a496b24a4753c
Gerrit-Change-Number: 47655
Gerrit-PatchSet: 11
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz@google.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Eizan Miyamoto <eizan@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Wed, 13 Jan 2021 00:16:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment