26 Oct
2021
26 Oct
'21
10:30 a.m.
Attention is currently required from: Nico Huber, Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58618 )
Change subject: Makefile: move utsname and clock_tettime test to the top ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File Makefile.d/clock_gettime_test.c:
https://review.coreboot.org/c/flashrom/+/58618/comment/a18612d4_2e7b043b PS1, Line 3: { I wonder why there's no void casts here
File Makefile.d/utsname_test.c:
https://review.coreboot.org/c/flashrom/+/58618/comment/ab72f4db_a2447d07 PS1, Line 7:
Drop spurious spaces?
Note: This one and the ones after the void casts.
--
To view, visit https://review.coreboot.org/c/flashrom/+/58618
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie1f43b3d5a8ad79bff3f9bbc21f359ec35abc42a
Gerrit-Change-Number: 58618
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Comment-Date: Tue, 26 Oct 2021 13:30:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment