Miklós Márton has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/39841 ) Change subject: udelay.c: Enable providing delay calibration value through CLI ...................................................................... Patch Set 1: (4 comments) https://review.coreboot.org/c/flashrom/+/39841/1//COMMIT_MSG Commit Message: https://review.coreboot.org/c/flashrom/+/39841/1//COMMIT_MSG@9 PS1, Line 9: This commit implements --delay option to retrieve and provide the calibration Use --loop-delay here as well https://review.coreboot.org/c/flashrom/+/39841/1/cli_classic.c File cli_classic.c: https://review.coreboot.org/c/flashrom/+/39841/1/cli_classic.c@67 PS1, Line 67: " --loop-delay get show loop delay calibration\n" I would suggest to rename the --loop-delay get to --get-loop-delay because I see no other arguments having second argument. But let's hear others opinion about it. https://review.coreboot.org/c/flashrom/+/39841/1/cli_classic.c@162 PS1, Line 162: {"delay", 1, NULL, 'd'}, The help was modified to use the loop-delay argument so this one should be as well. https://review.coreboot.org/c/flashrom/+/39841/1/udelay.c File udelay.c: https://review.coreboot.org/c/flashrom/+/39841/1/udelay.c@228 PS1, Line 228: /* Do a sanity check if the provided parameter makes loops fall within 10% of Please use tabs for the indentation of this comment. -- To view, visit https://review.coreboot.org/c/flashrom/+/39841 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iea2a7f62300663bc0a32ed4abced57c8c55c90c8 Gerrit-Change-Number: 39841 Gerrit-PatchSet: 1 Gerrit-Owner: Hrvoje Čavrak <github@hrvoje.org> Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com> Gerrit-Reviewer: Miklós Márton <martonmiklosqdev@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Wed, 25 Mar 2020 19:53:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment