[flashrom-gerrit] Change in flashrom[master]: sb600spi: Add spireadmode

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38833 )

Change subject: sb600spi: Add spireadmode
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/flashrom/+/38833/1/sb600spi.c 
File sb600spi.c:

https://review.coreboot.org/c/flashrom/+/38833/1/sb600spi.c@509 
PS1, Line 509: if (spispeed_idx >= 0 && set_speed(dev, spispeed_idx) != 0) {
             : 		return 1;
             : 	}
             : 	return 0;
> Well, if spispeed_idx is negative, the previous code would have barfed. […]

Well, the previous code defaulted to 3, so it never barfed. Still, I would consider it an error. I would at least print a warning if that happens.