View Change

1 comment:

• File sb600spi.c:

  • Patch Set #1, Line 509:

    if (spispeed_idx >= 0 && set_speed(dev, spispeed_idx) != 0) {
    		return 1;
    	}
    	return 0;
    

    Well, if spispeed_idx is negative, the previous code would have barfed. […]

    Well, the previous code defaulted to 3, so it never barfed. Still, I would consider it an error. I would at least print a warning if that happens.

To view, visit change 38833. To unsubscribe, or for help writing mail filters, visit settings.