30 Jan
2020
30 Jan
'20
10:51 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38596 )
Change subject: flashcips: Add Spansion S25FL512S ......................................................................
Patch Set 6: Code-Review+1
(2 comments)
https://review.coreboot.org/c/flashrom/+/38596/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/38596/6//COMMIT_MSG@7 PS6, Line 7: flashcips missing the 2nd `h`: flashcHips
https://review.coreboot.org/c/flashrom/+/38596/6/flashchips.c File flashchips.c:
https://review.coreboot.org/c/flashrom/+/38596/6/flashchips.c@15980 PS6, Line 15980: TEST_OK_PREW Did you test erase and write as well?
--
To view, visit https://review.coreboot.org/c/flashrom/+/38596
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ifa9b7615951125b6bbc1f051370ef54896bf506c
Gerrit-Change-Number: 38596
Gerrit-PatchSet: 6
Gerrit-Owner: Bernhard Urban-Forster lewurm@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 30 Jan 2020 22:51:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment