[flashrom-gerrit] [S] Change in flashrom[main]: flashchips: add support for MX77U51250F chip

[DZ (Code Review)]

Attention is currently required from: Anastasia Klimchuk, Bora Guvendik, Nikolai Artemiev, Stefan Reinauer, Subrata Banik.

DZ has posted comments on this change by Bora Guvendik. ( https://review.coreboot.org/c/flashrom/+/82626?usp=email )

Change subject: flashchips: add support for MX77U51250F chip
......................................................................

Patch Set 3: Code-Review+1

(3 comments)

File flashchips.c:

https://review.coreboot.org/c/flashrom/+/82626/comment/daebb496_d01d730b?usp... :
PS3, Line 11618: 65536
> I believe this is 64MB SPI flash. […]

Yes, the Flash density is 64MB

https://review.coreboot.org/c/flashrom/+/82626/comment/0801c80f_be67b82a?usp... :
PS3, Line 11620: 		.feature_bits	= FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA,
> it doesn't support FEATURE_WRSR2, FEATURE_WRSR3?

In the datasheet, this Flash doesn't support FEATURE_WRSR2, FEATURE_WRSR3.

https://review.coreboot.org/c/flashrom/+/82626/comment/c85853d3_a64343e8?usp... :
PS3, Line 11648: 	},
> please add below details as well
>    .reg_bits       =
>    	{
>    	...
>    	}
>         .decode_range

I think user don't have to add this detail if they haven't test the write protection function for this Flash.