Attention is currently required from: Anastasia Klimchuk, Bora Guvendik, Nikolai Artemiev, Stefan Reinauer, Subrata Banik.

Patch set 3:Code-Review +1

View Change

3 comments:

• File flashchips.c:

  • Patch Set #3, Line 11618: 65536

    I believe this is 64MB SPI flash. […]

    Yes, the Flash density is 64MB

  • Patch Set #3, Line 11620: .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA,

    it doesn't support FEATURE_WRSR2, FEATURE_WRSR3?

    In the datasheet, this Flash doesn't support FEATURE_WRSR2, FEATURE_WRSR3.

  • Patch Set #3, Line 11648: },

    please add below details as well

    ```
    	.reg_bits       =
    		{
    		...
    		}
            .decode_range
    ```

    I think user don't have to add this detail if they haven't test the write protection function for this Flash.

To view, visit change 82626. To unsubscribe, or for help writing mail filters, visit settings.