[flashrom-gerrit] Change in flashrom[master]: tests/: Add spi.c unit tests

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41644 )

Change subject: tests/: Add spi.c unit tests
......................................................................

Patch Set 2:

(6 comments)

https://review.coreboot.org/c/flashrom/+/41644/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/flashrom/+/41644/2//COMMIT_MSG@11 
PS2, Line 11: builds
but do the tests pass?

https://review.coreboot.org/c/flashrom/+/41644/2/tests/spi.c 
File tests/spi.c:

https://review.coreboot.org/c/flashrom/+/41644/2/tests/spi.c@15 
PS2, Line 15: 0xAA55
Magic number?

https://review.coreboot.org/c/flashrom/+/41644/2/tests/spi.c@36 
PS2, Line 36: NULL,0,0,NULL,NULL
Shouldn't we have spaces around here?

https://review.coreboot.org/c/flashrom/+/41644/2/tests/spi.c@44 
PS2, Line 44: programmer_init(
            : 			CONFIG_DEFAULT_PROGRAMMER,
            : 			strdup(CONFIG_DEFAULT_PROGRAMMER_ARGS)
Why not use a variable for this one as well?

https://review.coreboot.org/c/flashrom/+/41644/2/tests/spi.c@50 
PS2, Line 50: ,
This comma shouldn't be needed

https://review.coreboot.org/c/flashrom/+/41644/2/tests/spi.c@51 
PS2, Line 51: &registered_masters[0]
registered_masters