View Change

6 comments:

• Commit Message:

  • Patch Set #2, Line 11: builds

    but do the tests pass?

• File tests/spi.c:

  • Patch Set #2, Line 15: 0xAA55

    Magic number?

  • Patch Set #2, Line 36: NULL,0,0,NULL,NULL

    Shouldn't we have spaces around here?

  • Patch Set #2, Line 44:

    programmer_init(
    			CONFIG_DEFAULT_PROGRAMMER,
    			strdup(CONFIG_DEFAULT_PROGRAMMER_ARGS)
    

    Why not use a variable for this one as well?

  • Patch Set #2, Line 50: ,

    This comma shouldn't be needed

  • Patch Set #2, Line 51: &registered_masters[0]

    registered_masters

To view, visit change 41644. To unsubscribe, or for help writing mail filters, visit settings.