Namyoon Woo has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44879 )
Change subject: support variable-size SPI chip for dummy programmer
......................................................................
Patch Set 6:
(1 comment)
Patch Set 2: Code-Review-1
(8 comments)
I don't like the parsing of the command-line parameters at all.
In patchset#6, I removed SIZE_AUTO and 'k|K|m|M' prefix handling in size parameter for simplicity.
https://review.coreboot.org/c/flashrom/+/44879/2/dummyflasher.c
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/44879/2/dummyflasher.c@a379
PS2, Line 379: /* Will be freed by shutdown function if necessary. */
This is moved to above line 347, because it needed to stat emu_persistent_image in case that SIZE_AU […]
I am bring this back here.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/44879
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iff266e151459561b126ecfd1c47420b385be1db2
Gerrit-Change-Number: 44879
Gerrit-PatchSet: 6
Gerrit-Owner: Namyoon Woo
namyoon@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Namyoon Woo
namyoon@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 01 Sep 2020 00:47:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Namyoon Woo
namyoon@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment