Patch Set 2: Code-Review-1


I don't like the parsing of the command-line parameters at all.

In patchset#6, I removed SIZE_AUTO and 'k|K|m|M' prefix handling in size parameter for simplicity.

View Change

1 comment:

To view, visit change 44879. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iff266e151459561b126ecfd1c47420b385be1db2
Gerrit-Change-Number: 44879
Gerrit-PatchSet: 6
Gerrit-Owner: Namyoon Woo <>
Gerrit-Reviewer: Angel Pons <>
Gerrit-Reviewer: Edward O'Callaghan <>
Gerrit-Reviewer: Namyoon Woo <>
Gerrit-Reviewer: build bot (Jenkins) <>
Gerrit-CC: Paul Menzel <>
Gerrit-Comment-Date: Tue, 01 Sep 2020 00:47:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Namyoon Woo <>
Comment-In-Reply-To: Angel Pons <>
Gerrit-MessageType: comment