[flashrom-gerrit] [M] Change in flashrom[master]: tree: Move PCI IDs into their own header file

[Angel Pons (Code Review)]

Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66864 )

Change subject: tree: Move PCI IDs into their own header file
......................................................................

Patch Set 6:

(1 comment)

Patchset:

PS5:
> > > nobody cares how the local code looks like. […]

IMHO I believe flashrom doesn't benefit from vendor/device ID macros in most cases, as we have a string associated with VID/PID pairs, e.g. chipset_enable.c `chipset_enables` array. We rarely need to reference device IDs more than once.

The only place where I see a bit of redundancy is in nicintel code: flashrom has two separate programmers for SPI and EEPROM, and there are NICs with both. So some IDs appear in two files. I don't see a good way to unify this that can be considered an improvement.