Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen.

View Change

1 comment:

• Patchset:

  • Patch Set #5:

    > > nobody cares how the local code looks like. […]

    IMHO I believe flashrom doesn't benefit from vendor/device ID macros in most cases, as we have a string associated with VID/PID pairs, e.g. chipset_enable.c `chipset_enables` array. We rarely need to reference device IDs more than once.

    The only place where I see a bit of redundancy is in nicintel code: flashrom has two separate programmers for SPI and EEPROM, and there are NICs with both. So some IDs appear in two files. I don't see a good way to unify this that can be considered an improvement.

To view, visit change 66864. To unsubscribe, or for help writing mail filters, visit settings.