David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/43051 )
Change subject: serial: Fix file read/write error handling for Windows ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/flashrom/+/43051/1/serial.c File serial.c:
https://review.coreboot.org/c/flashrom/+/43051/1/serial.c@494 PS1, Line 494: != true
this is painful
I'm open to suggestions... If it's a style thing then perhaps that's a good reason to move ahead with CB:42556 ;-) IMO it might also be nice to refactor this file and move all these #if and #else blocks into helper functions to unclutter the loops.
But for now I just want to un-break the build.