View Change
1 comment:
File serial.c:
Patch Set #1, Line 494: != true
this is painful
I'm open to suggestions... If it's a style thing then perhaps that's a good reason to move ahead with CB:42556 ;-) IMO it might also be nice to refactor this file and move all these #if and #else blocks into helper functions to unclutter the loops.
But for now I just want to un-break the build.
To view, visit change 43051. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib179d51ede2dbd38f54f3641bfe90340a6a87e31
Gerrit-Change-Number: 43051
Gerrit-PatchSet: 1
Gerrit-Owner: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Miklós Márton <martonmiklosqdev@gmail.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Fri, 03 Jul 2020 23:10:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Gerrit-MessageType: comment