Brian Nemec has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/41533 )
Change subject: raiden_debug_spi.c: Adds support for USB SPI protocol V2 ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/flashrom/+/41533/3/raiden_debug_spi.c File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/41533/3/raiden_debug_spi.c@722 PS3, Line 722: nd_command_v1(co
seems like a change for the previous patches
Ack
https://review.coreboot.org/c/flashrom/+/41533/3/raiden_debug_spi.c@1108 PS3, Line 1108: NULL,
was this tested..? This would clearly break this spi master.
Yes, it was tested on the version of flashrom in chromeos.
The null pointer is replaced during the initialization phase during the configure_protocol() function call and before we register the spi_master. This pointer will either be set to send_command_v1 or send_command_v2. It only remains a null pointer if initialization fails.