View Change

2 comments:

• File raiden_debug_spi.c:

  • Patch Set #3, Line 722: nd_command_v1(co

    seems like a change for the previous patches

    Ack

  • Patch Set #3, Line 1108: NULL,

    was this tested..? This would clearly break this spi master.

    Yes, it was tested on the version of flashrom in chromeos.

    The null pointer is replaced during the initialization phase during the configure_protocol() function call and before we register the spi_master. This pointer will either be set to send_command_v1 or send_command_v2. It only remains a null pointer if initialization fails.

To view, visit change 41533. To unsubscribe, or for help writing mail filters, visit settings.