Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46064 )
Change subject: WIP: flashchips.c: import chips from cros flashrom ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/flashrom/+/46064/2/flashchips.h File flashchips.h:
https://review.coreboot.org/c/flashrom/+/46064/2/flashchips.h@945 PS2, Line 945: /* : * W25Q128 has several variants. Currently all are 3.3V except for the W25Q128FW : * which is 1.8V. Otherwise they should behave the same... : */ : #define WINBOND_NEX_W25Q128_V 0x4018 /* W25Q128BV, W25Q128FV (SPI mode), W25Q128JV */ : #define WINBOND_NEX_W25Q256_V 0x4019 /* W25Q256FV or W25Q256JV_Q (QE=1) */ : #define WINBOND_NEX_W25Q512JV 0x4020 /* W25Q512JV */ : #define WINBOND_NEX_W25Q20_W 0x5012 /* W25Q20BW */ : #define WINBOND_NEX_W25Q40BW 0x5013 /* W25Q40BW */ : #define WINBOND_NEX_W25Q80BW 0x5014 /* W25Q80BW */ : #define WINBOND_NEX_W25Q40EW 0x6013 /* W25Q40EW */ : #define WINBOND_NEX_W25Q80EW 0x6014 /* W25Q80EW */ : #define WINBOND_NEX_W25Q16_W 0x6015 /* W25Q16DW */ : #define WINBOND_NEX_W25Q32_W 0x6016 /* W25Q32DW; W25Q32FV in QPI mode */ : #define WINBOND_NEX_W25Q64_W 0x6017 /* W25Q64DW; W25Q64FV in QPI mode */ : #define WINBOND_NEX_W25Q128_W 0x6018 /* Same as W25Q128FV (QPI mode), W25R128FV */ : #define WINBOND_NEX_W25Q128FW 0x6018 /* Same as W25Q128FV (QPI mode), W25R128FV */ : #define WINBOND_NEX_W25Q256_W 0x6019 /* W25Q256JW */ : #define WINBOND_NEX_W25Q128_V_M 0x7018 /* W25Q128JVSM */ : #define WINBOND_NEX_W25Q256JV_M 0x7019 /* W25Q256JV_M (QE=0) */ : #define WINBOND_NEX_W25Q32JW 0x8016 ditto.
https://review.coreboot.org/c/flashrom/+/46064/2/flashchips.c File flashchips.c:
https://review.coreboot.org/c/flashrom/+/46064/2/flashchips.c@17197 PS2, Line 17197: .name = "W25Q32JW", : .bustype = BUS_SPI, : .manufacture_id = WINBOND_NEX_ID, : .model_id = WINBOND_NEX_W25Q32JW, : .total_size = 4096, : .page_size = 256, : .feature_bits = FEATURE_WRSR_WREN, : .tested = TEST_OK_PREW, : .probe = probe_spi_rdid, : .probe_timing = TIMING_ZERO, : .block_erasers = : { : { : .eraseblocks = { {4 * 1024, 1024} }, : .block_erase = spi_block_erase_20, : }, { : .eraseblocks = { {32 * 1024, 128} }, : .block_erase = spi_block_erase_52, : }, { : .eraseblocks = { {64 * 1024, 64} }, : .block_erase = spi_block_erase_d8, : }, { : .eraseblocks = { {4 * 1024 * 1024, 1} }, : .block_erase = spi_block_erase_60, : }, { : .eraseblocks = { {4 * 1024 * 1024, 1} }, : .block_erase = spi_block_erase_c7, : } : }, : .unlock = spi_disable_blockprotect, : .write = spi_chip_write_256, : .read = spi_chip_read, : .voltage = {1700, 1950}, : }, : : { : .vendor = "Winbond", non-spansion related, separate out.