Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35800 )
Change subject: Fix more sign-compare issues ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/flashrom/+/35800/2/ich_descriptors.c File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/35800/2/ich_descriptors.c@424 PS2, Line 424: min
Would be nice to have a min() that didn't cast everything to int, but that can wait till later.
Ack. I actually have that in another patch train, IIRC. A simple macro, though, that is *not* double-evaluation safe. It seems impossible to implement that in ISO C (missing `typeof`), unless we'd go for a generic template, but then the compiler would have to be new enough...