Alan Green has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33931 )
Change subject: flashchips.c: Sort file by vendor and model ......................................................................
Patch Set 5:
(1 comment)
Patch Set 3: Code-Review-1
(1 comment)
This doesn't seem to adhere to the currently defined order. I wouldn't mind to change that definition, though. Also, the post-merge plans are better discussed on the mailing list. There are other people that have plans too :) For instance during the OSF Hackathon in June [1], we discussed making it an easier to handle ASCII file, that can (optionally) be compiled into C.
[1] http://docs.google.com/document/d/18qKvEbfPszjsJJGJhwi8kRVDUG3GZkADzQSH6WFsK...
Thank you for the additional context. It is helpful.
I removed mention of possible future directions from the change description to avoid confusion.
https://review.coreboot.org/#/c/33931/3/flashchips.c File flashchips.c:
https://review.coreboot.org/#/c/33931/3/flashchips.c@29 PS3, Line 29: Within families keep them in order of density.
I suppose this is not true anymore after this patch?
You're right. Thank you for pointing it out. I update the comment to match the new reality.