Patch Set 3: Code-Review-1

(1 comment)

This doesn't seem to adhere to the currently defined order.
I wouldn't mind to change that definition, though. Also, the
post-merge plans are better discussed on the mailing list.
There are other people that have plans too :) For instance
during the OSF Hackathon in June [1], we discussed making
it an easier to handle ASCII file, that can (optionally)
be compiled into C.

[1] http://docs.google.com/document/d/18qKvEbfPszjsJJGJhwi8kRVDUG3GZkADzQSH6WFsKqw/

Thank you for the additional context. It is helpful.

I removed mention of possible future directions from the change description to avoid confusion.

View Change

1 comment:

• File flashchips.c:

  • Patch Set #3, Line 29: Within families keep them in order of density.

    I suppose this is not true anymore after this patch?

    You're right. Thank you for pointing it out. I update the comment to match the new reality.

To view, visit change 33931. To unsubscribe, or for help writing mail filters, visit settings.