[flashrom-gerrit] Change in flashrom[master]: [WIP] meson: rework the programmer selection

[Anastasia Klimchuk (Code Review)]

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63724 )

Change subject: [WIP] meson: rework the programmer selection
......................................................................

Patch Set 11:

(2 comments)

Commit Message:

https://review.coreboot.org/c/flashrom/+/63724/comment/d7eed736_13c1897c 
PS11, Line 10: has some known and unknown bugs.
Speaking about bugs, and especially unknown bugs, can we collectively try detect them? Is this patch ready to be downloaded locally and built with various combinations of options?

File meson.build:

https://review.coreboot.org/c/flashrom/+/63724/comment/4164d880_ce8cc1e6 
PS7, Line 212: 	'internal' : {
             : 		'systems' : systems_raw_hwaccess + ['linux'],
             : 		'cpu_families' : (host_machine.system() == 'linux' ? [host_machine.cpu_family()] : ['x86', 'x86_64']),
             : 		'deps'    : [ libpci ],
             : 		'groups'  : [ ],
             : 		'srcs'    : (host_machine.cpu_family() in ['x86', 'x86_64'] ? files(
             : 			'processor_enable.c',
             : 			'chipset_enable.c',
             : 			'board_enable.c',
             : 			'cbtable.c',
             : 			'internal.c',
             : 			'it87spi.c',
             : 			'it85spi.c',
             : 			'sb600spi.c',
             : 			'amd_imc.c',
             : 			'wbsio_spi.c',
             : 			'mcp6x_spi.c',
             : 			'ichspi.c',
             : 			'dmi.c',
             : 			'pcidev.c',
             : 		) : files(
             : 			'board_enable.c',
             : 			'cbtable.c',
             : 			'chipset_enable.c',
             : 			'internal.c',
             : 			'processor_enable.c',
             : 			'pcidev.c',
             : 		)),
             : 		'flags' : [
             : 			'-DCONFIG_INTERNAL=1',
             : 			'-DCONFIG_INTERNAL_DMI=' + (get_option('use_internal_dmi') ? '1' : '0'),
             : 		]
             : 	},
> This should work. I only discovered this possibility while working on the code. […]

Thank you, good to know that refactoring internal is not blocking further work on build system. I agree this needs to be done, but good to know it's not blocking.