Attention is currently required from: Nikolai Artemiev.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69195 )
Change subject: ichspi.c: Read chip ID and use it to identify chip ......................................................................
Patch Set 2:
(8 comments)
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/69195/comment/894d29fb_0da1439d PS2, Line 1472: entry == NULL `!entry`
https://review.coreboot.org/c/flashrom/+/69195/comment/350c6139_b671d4f4 PS2, Line 1475: return 0; `return -1;`
https://review.coreboot.org/c/flashrom/+/69195/comment/f2c77aa2_b2a83d5c PS2, Line 1476: } else { no need for a `else` as you have a early return in the `if` branch.
https://review.coreboot.org/c/flashrom/+/69195/comment/1d289c72_cc5b605e PS2, Line 1486: flash->chip->tested = entry->tested; drop line, it is overwritten in the eulogy of `ich_hwseq_probe()`, the call site of this function.
https://review.coreboot.org/c/flashrom/+/69195/comment/d11146c5_876f4a3f PS2, Line 1492: return 1; `return 0;`
https://review.coreboot.org/c/flashrom/+/69195/comment/59afdf05_ac4142af PS2, Line 1502: != 1 `< 0`
https://review.coreboot.org/c/flashrom/+/69195/comment/765bad5e_418f1a21 PS2, Line 1503: msg_perr("Unable to read flash chip ID\n"); drop as you already have a `msg_perr()` call in the func.
https://review.coreboot.org/c/flashrom/+/69195/comment/1440fe6d_2b9237e9 PS2, Line 1552: TEST_OK_PREW; https://review.coreboot.org/c/flashrom/+/69518
`TEST_OK_PREWB;`