22 Jun
2019
22 Jun
'19
1:09 a.m.
David Tomaschik has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33639 )
Change subject: Add support for MX25U25635F ......................................................................
Patch Set 2:
Patch Set 1: Code-Review+1
(2 comments)
Thanks for your patch. There's one nit in the commit message and some missed erase block commands to be added. Then it's ready to go.
I believe I've addressed the comments you had, but please let me know if I've not done it correctly. This is my first time contributing to this project, but I think I've covered it.
--
To view, visit https://review.coreboot.org/c/flashrom/+/33639
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5bdcd32acd1942edf65e50bce0f81c836095ee8c
Gerrit-Change-Number: 33639
Gerrit-PatchSet: 2
Gerrit-Owner: David Tomaschik davidtomaschik@google.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: David Tomaschik davidtomaschik@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 22 Jun 2019 01:09:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment