Victor Ding has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44541 )
Change subject: Add MEC1308 EC programmer ......................................................................
Patch Set 6:
(2 comments)
File Makefile:
https://review.coreboot.org/c/flashrom/+/44541/comment/8774010b_bb9d2238 PS6, Line 187: endif
Why?
The code was ported from Chromium's flashrom fork, I don't think it has ever been verified on DOS; therefore, I decided this configuration shouldn't be allowed until tested when submitting this patch. WDYT?
https://review.coreboot.org/c/flashrom/+/44541/comment/7dde53ce_3677cf76 PS6, Line 418: endif
Why?
The code was ported from Chromium's flashrom fork, I don't think it has ever been verified on libpayload; therefore, I decided this configuration shouldn't be allowed until tested when submitting this patch. WDYT?