View Change
2 comments:
File Makefile:
Patch Set #6, Line 187: endif
Why?
The code was ported from Chromium's flashrom fork, I don't think it has ever been verified on DOS; therefore, I decided this configuration shouldn't be allowed until tested when submitting this patch. WDYT?
Patch Set #6, Line 418: endif
Why?
The code was ported from Chromium's flashrom fork, I don't think it has ever been verified on libpayload; therefore, I decided this configuration shouldn't be allowed until tested when submitting this patch. WDYT?
To view, visit change 44541. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2d51b4bdc0b38b6e488e71b9e774eb6232a2069e
Gerrit-Change-Number: 44541
Gerrit-PatchSet: 6
Gerrit-Owner: Victor Ding <victording@google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Comment-Date: Mon, 28 Jun 2021 06:34:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment