Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47090 )
Change subject: chipset_enable.c: Add Intel pch6 did=0x1e4{1,2,3} support
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/flashrom/+/47090/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/flashrom/+/47090/1//COMMIT_MSG@7
PS1, Line 7: pid
did (Device ID)
Done
https://review.coreboot.org/c/flashrom/+/47090/1/chipset_enable.c
File chipset_enable.c:
https://review.coreboot.org/c/flashrom/+/47090/1/chipset_enable.c@1842
PS1, Line 1842: OK
These should be `DEP` like the other PCHs are
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/47090
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic69dc024e9af0c43d6b3a8213a5dc5d2f898c447
Gerrit-Change-Number: 47090
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 13 Nov 2020 08:11:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment