[flashrom-gerrit] [M] Change in flashrom[master]: opaque: make opaque programmers expose register read/write capability

[Nikolai Artemiev (Code Review)]

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Sergii Dmytruk.

Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66032 )

Change subject: opaque: make opaque programmers expose register read/write capability
......................................................................

Patch Set 3:

(1 comment)

File ichspi.c:

https://review.coreboot.org/c/flashrom/+/66032/comment/255a7293_2eaf13b1 
PS2, Line 1413: static bool ich_hwseq_can_read_register(const struct flashctx *flash, enum flash_reg reg)
              : {
              : 	return reg == STATUS1;
              : }
              : 
              : static bool ich_hwseq_can_write_register(const struct flashctx *flash, enum flash_reg reg)
              : {
              : 	return reg == STATUS1;
              : }
> It might be better to use functions instead of structs, given the many-to-one relationship between d […]

Marking resolved, reopen if you want to discuss it more though.