Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Sergii Dmytruk.

View Change

1 comment:

• File ichspi.c:

  • Patch Set #2, Line 1413:

    static bool ich_hwseq_can_read_register(const struct flashctx *flash, enum flash_reg reg)
    {
    	return reg == STATUS1;
    }
    
    static bool ich_hwseq_can_write_register(const struct flashctx *flash, enum flash_reg reg)
    {
    	return reg == STATUS1;
    }
    

    It might be better to use functions instead of structs, given the many-to-one relationship between d […]

    Marking resolved, reopen if you want to discuss it more though.

To view, visit change 66032. To unsubscribe, or for help writing mail filters, visit settings.