15 Oct
2020
15 Oct
'20
3:42 a.m.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/46439 )
Change subject: it87spi.c: return error when probe fails ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/flashrom/+/46439/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/46439/1//COMMIT_MSG@9 PS1, Line 9: Make it87spi_probe() return error to match CrOS flashrom. https://chromium-review.googlesource.com/175974
The downstream patch is here and includes a lot more than this change. You may wish to cite it and check if there is anything else like, does the call site expect this change of behavior?
--
To view, visit https://review.coreboot.org/c/flashrom/+/46439
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie122c4f954d14c713fb719ec44200b2def00fed6
Gerrit-Change-Number: 46439
Gerrit-PatchSet: 1
Gerrit-Owner: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 15 Oct 2020 03:42:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment