Attention is currently required from: Nico Huber, Edward O'Callaghan. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52597 )
Change subject: mec1308.c: Separate shutdown from failed init cleanup ......................................................................
Patch Set 3:
(2 comments)
File mec1308.c:
https://review.coreboot.org/c/flashrom/+/52597/comment/4c53f134_01b40c5c PS2, Line 496: goto mec1308_init_exit;
It's becoming more and more obvious that the original cleanup procedure […]
I noticed this in other places, that shutdown != cleanup and all of them I want to sort eventually. I took the approach not to change current behavior as a first step.
I can do "partial cleanup" for the case when SMI failed to be disabled, but that would be changing current behavior here, so maybe in the separate patch? What do you think?
https://review.coreboot.org/c/flashrom/+/52597/comment/4075bf85_95d49bcb PS2, Line 519: failed_init_cleanup: : mec1308_shutdown(ctx_data); : return 1; : : mec1308_init_exit:
Would be nice to align the label names somehow. I first thought "aren't […]
My second attempt is init_err_cleanup_exit init_err_exit