Attention is currently required from: Nico Huber, Edward O'Callaghan.

View Change

2 comments:

• File mec1308.c:

  • Patch Set #2, Line 496: goto mec1308_init_exit;

    It's becoming more and more obvious that the original cleanup procedure […]

    I noticed this in other places, that shutdown != cleanup and all of them I want to sort eventually. I took the approach not to change current behavior as a first step.

    I can do "partial cleanup" for the case when SMI failed to be disabled, but that would be changing current behavior here, so maybe in the separate patch? What do you think?

  • Patch Set #2, Line 519:

    failed_init_cleanup:
    	mec1308_shutdown(ctx_data);
    	return 1;
    
    mec1308_init_exit:
    

    Would be nice to align the label names somehow. I first thought "aren't […]

    My second attempt is
    init_err_cleanup_exit
    init_err_exit

To view, visit change 52597. To unsubscribe, or for help writing mail filters, visit settings.