Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/44621 )
Change subject: allow 0x34 as ICCRIBA for CHIPSET_C620_SERIES_LEWISBURG ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/flashrom/+/44621/1/ich_descriptors.c File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/44621/1/ich_descriptors.c@1248 PS1, Line 1248: "__FUNC__, __LINE__ Failed with value %d.\n", ret I don't think we're supposed to print anything in here, but let the callers handle errors instead. Plus, it could happen that a descriptor isn't present, which isn't an error.
In any case, this will print `__FUNC__, __LINE__` literally. If anything, I'd print something more user-friendly instead of function and line numbers.
https://review.coreboot.org/c/flashrom/+/44621/1/ich_descriptors.c@1248 PS1, Line 1248: msg_cerr msg_perr