Patch set 1:Code-Review +1

View Change

2 comments:

• File ich_descriptors.c:

  • Patch Set #1, Line 1248: "__FUNC__, __LINE__ Failed with value %d.\n", ret

    I don't think we're supposed to print anything in here, but let the callers handle errors instead. Plus, it could happen that a descriptor isn't present, which isn't an error.

    In any case, this will print `__FUNC__, __LINE__` literally. If anything, I'd print something more user-friendly instead of function and line numbers.

  • Patch Set #1, Line 1248: msg_cerr

    msg_perr

To view, visit change 44621. To unsubscribe, or for help writing mail filters, visit settings.